Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tests): add visual tests for content - INNO-649 #289

Merged
merged 4 commits into from
Jul 18, 2017
Merged

feat(tests): add visual tests for content - INNO-649 #289

merged 4 commits into from
Jul 18, 2017

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Jul 17, 2017 •
edited
Loading

PR description

Add tests for "content" folder.
Replace PR 243

QA Checklist

In order to ensure a safe and quick review, please check that your PR follow those guidelines:

  • package.json is up-to-date and @ec-europa/ecl-base is part of the dependencies
  • I have given the fractal status “ready” to my component
  • I have declared @define mycomponent in the SCSS file
  • I have specified margin: 0; on the CSS component
  • I have provided tests
  • I follow the naming guidelines
  • the component supports composition
  • the template is fully functional
  • I have filled the README.md file (at least a few lines)
  • I have checked the dependencies
  • there are no hardcoded strings (all content come from the context)

@emeryro emeryro changed the title feat(tests): add visual tests for content feat(tests): add visual tests for content - INNO-649 Jul 17, 2017
@emeryro emeryro requested a review from yhuard July 17, 2017 12:52
@degliwe degliwe self-assigned this Jul 17, 2017
degliwe
degliwe previously approved these changes Jul 17, 2017
View reviewed changes
Copy link
Contributor

@degliwe degliwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good

@yhuard yhuard mentioned this pull request Jul 17, 2017
Closed
yhuard
yhuard suggested changes Jul 17, 2017
View reviewed changes
Copy link
Contributor

@yhuard yhuard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json hasn't changed, yarn.lock should not have been updated, please remove it from the PR ;)

@yhuard yhuard merged commit cb7da9a into master Jul 18, 2017
@yhuard yhuard deleted the feat/style-test-INNO-649 branch July 18, 2017 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhuard yhuard yhuard requested changes

@degliwe degliwe degliwe left review comments

Assignees

@degliwe degliwe

Labels
tag: enhancement tag: internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emeryro @degliwe @yhuard