Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(updates): update docs - INNO-713 #306

Merged
merged 2 commits into from
Jul 21, 2017
Merged

docs(updates): update docs - INNO-713 #306

merged 2 commits into from
Jul 21, 2017

Conversation

yhuard
Copy link
Contributor

@yhuard yhuard commented Jul 21, 2017

PR description

Please drop a few lines about the PR: what it does, how to test it, etc.

QA Checklist

In order to ensure a safe and quick review, please check that your PR follow those guidelines:

  • package.json is up-to-date and @ec-europa/ecl-base is part of the dependencies
  • I have checked the dependencies
  • I have given the fractal status “ready” to my component
  • I have declared @define mycomponent in the SCSS file
  • I have specified margin: 0; on the CSS component
  • I have provided tests
  • I follow the naming guidelines
  • the component supports composition
  • there are no hardcoded strings (all content come from the context)
  • I have filled the README.md file (at least a few lines)
  • My PR has the right label(s)

@ghost
Copy link

ghost commented Jul 21, 2017

Your pull request doesn't follow our guidelines. Please fix the following:

  • Pull request title must have one of the following prefixes: "feat(*): ", "fix(*): ", "docs(*): ", "style(*): ", "refactor(*): ", "perf(*): ", "test(*): ", "chore(*): " (?)

Click here for details.

Thank you! 🙏

This comment was made by GitMagic – Magically enforcing your contribution guidelines.

@yhuard yhuard changed the title doc(updates): update docs - INNO-713 docs(updates): update docs - INNO-713 Jul 21, 2017
@ghost
Copy link

ghost commented Jul 21, 2017

Thank you, the title and description now looks good! :bowtie:

@yhuard yhuard merged commit 9652f0e into master Jul 21, 2017
@yhuard yhuard deleted the doc/updates branch July 21, 2017 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant