feat(table): table without header - FRONT-4437 #3407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
emeryro
commented
May 28, 2024
emeryro
commented
- add a border top to the table when there is no header
- add a control in Storybook to preview it
planctus
reviewed
Jun 17, 2024
| @@ -28,7 +40,15 @@ const getArgTypes = () => ({ | |||
| }, | |||
| }); | |||
|
|
|||
| const prepareData = (data, args) => Object.assign(data, args); | |||
| const prepareData = (data, args) => { | |||
There was a problem hiding this comment.
this way we break the simple control, we should still return an Object.assign to get it working again.
planctus
requested changes
Jun 17, 2024
|
right, but isn't it better actually to completely hide the "simple" control after setting in it to true when the user chooses to hide the headers ? What happens currently is that you choose to remove the headers but then you still see them in mobile because of the attribute set, which appears as "magical".. :) |
planctus
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.