Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form): update style of all form elements - FRONT-4432 #3421

Merged
merged 14 commits into from
Jul 11, 2024

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Jun 5, 2024

  • update font and spacing for several form elements
  • reduce differences between EC and EU

Copy link

github-actions bot commented Jun 5, 2024

@github-actions github-actions bot temporarily deployed to pull request June 5, 2024 11:14 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 5, 2024 11:30 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 10, 2024 09:52 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 11, 2024 07:56 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 11, 2024 08:08 Inactive

const getArgs = (data) => {
const args = {
show_label: true,
show_helper: true,
show_error: true,
width: data.input.width || 'm',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this we get the width control everywhere, even where it is not relevant, like in the checkbox

@github-actions github-actions bot temporarily deployed to pull request July 9, 2024 06:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 9, 2024 09:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 9, 2024 09:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 10, 2024 09:46 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 10, 2024 10:01 Inactive
@emeryro emeryro merged commit cb61a17 into v4-dev Jul 11, 2024
7 checks passed
@emeryro emeryro deleted the FRONT-4432-form-style branch July 11, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants