-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gallery): add grid display - FRONT-4459 #3434
Conversation
The columns control doesn't seem to do anything, i see the reason why, the css is missing an & for the columns selectors
|
…a/europa-component-library into FRONT-4459-gallery-grid
{% if _grid %} | ||
{% set _css_class = _css_class ~ ' ecl-gallery--grid' %} | ||
|
||
{% if _column is not empty %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we set the default to 3 for the column..
{% set _css_class = _css_class ~ ' ecl-gallery--col-' ~ _column %} | ||
{% endif %} | ||
|
||
{% if _ratio is not empty %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here for the ratio, it cannot be empty, basically..
grid
column
andratio