Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(custom-properties): Adding custom props for font family, using them in the components - FRONT-4490 #3460

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

planctus
Copy link
Contributor

@planctus planctus commented Jul 2, 2024

Didn't make sense to apply this only to the link component, so all the usage of font-family in our sass are now using the custom-properties for the font-family added in this pr.

Copy link

github-actions bot commented Jul 2, 2024

@github-actions github-actions bot temporarily deployed to pull request July 2, 2024 13:45 Inactive
Copy link
Contributor

@emeryro emeryro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine for me. We would just have to make it clear to the requester that we are using different css properties here (and not the full font properties), so they have to override them

@emeryro emeryro merged commit 4bbb55a into v4-dev Jul 3, 2024
7 checks passed
@emeryro emeryro deleted the FRONT-4490-Font-family-custom-prop branch July 3, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants