Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(menus): Removing role application from the inner section of the menus - FRONT-4568 #3559

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

planctus
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Aug 12, 2024

@github-actions github-actions bot temporarily deployed to pull request August 12, 2024 08:26 Inactive
@emeryro
Copy link
Contributor

emeryro commented Aug 13, 2024

So, it seems to work for the mega menu (with some limitation considered as normal by Regine), but not for the single menu: items can no longer be opened when using a screen reader.
I'll try to see why

@github-actions github-actions bot temporarily deployed to pull request August 13, 2024 08:13 Inactive
@emeryro
Copy link
Contributor

emeryro commented Aug 13, 2024

It should be fine now.
@planctus I let you have a look with the latest change, to check for regression

@github-actions github-actions bot temporarily deployed to pull request August 14, 2024 08:25 Inactive
@planctus planctus merged commit 51fc12f into v4-dev Aug 14, 2024
6 of 7 checks passed
@planctus planctus deleted the FRONT-4568-Menu-role branch August 14, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants