Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(carousel): Styles update - FRONT-4571 #3583

Merged
merged 21 commits into from
Sep 5, 2024
Merged

Conversation

planctus
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Aug 23, 2024

@github-actions github-actions bot temporarily deployed to pull request August 23, 2024 14:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 26, 2024 07:47 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 26, 2024 08:27 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 26, 2024 13:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 26, 2024 14:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 27, 2024 13:19 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 27, 2024 14:29 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 27, 2024 17:01 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 28, 2024 09:02 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 29, 2024 10:41 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 29, 2024 12:43 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 2, 2024 08:48 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 3, 2024 07:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 3, 2024 10:12 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 5, 2024 10:58 Inactive
Copy link
Contributor

@emeryro emeryro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I didn't know that scroll-snap-align property...

@emeryro emeryro merged commit b4f0a40 into v4-dev Sep 5, 2024
7 of 8 checks passed
@emeryro emeryro deleted the FRONT-4571-Carousel-update branch September 5, 2024 11:10
planctus added a commit that referenced this pull request Sep 6, 2024
* feat(carousel): Using pause-outline icon - FRONT-4571

* feat(carousel): Styles - FRONT-4571

* feat(carousel): Increasing margin in controls for EC - FRONT-4571

* feat(carousel): Alignment of the play button in large viewports - FRONT-4571

* feat(carousel): Reintroducing shadows, removing border bottom - FRONT-4571

* feat(carousel): Padding in the controls area - FRONT-4571

* feat(carousel): Single slide display, hiding element initially - FRONT-4571

* feat(carousel): Removing debug - FRONT-4571

* feat(carousel): fixing full width use case - FRONT-4571

* feat(carousel): Only hide on init - FRONT-4571

* feat(carousel): Adding text in the demo for grid content - FRONT-4571

* feat(carousel): Consistent calculations removing the scrollbar before rendering - FRONT-4571

* feat(carousel): Css only layout, js is only sliding now - FRONT-4571

---------

Co-authored-by: Romain Emery <emery.romain@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants