Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mega-menu): Showing the panels only when ready - FRONT-4604 #3610

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

planctus
Copy link
Contributor

@planctus planctus commented Sep 6, 2024

No description provided.

Copy link

github-actions bot commented Sep 6, 2024

@github-actions github-actions bot temporarily deployed to pull request September 6, 2024 09:02 Inactive
@emeryro
Copy link
Contributor

emeryro commented Sep 9, 2024

Not fully sure about this... The result is indeed cleaner, but now we are introducing a small delay every time we open a mega menu item.
On the other hand that would be tricky to do it differently, as we need to have the component "displayed" to do the calculus...
I did some test by setting height:100% on .ecl-mega-menu__mega (instead of calculating it with js. It seems to improve things a little (without your js update), but there are some other side effects when the mega item is smaller by default.

@planctus
Copy link
Contributor Author

planctus commented Sep 9, 2024

But to me it's just a matter of "getting used" to this new "smoothness", we still had to "wait" a bit to get everything in the right place, so we just avoiding showing the items while still adjusting them. We are not used to do this, but recently we applied the same approach to the carousel and also there it feels like an improvement, no need to render immediately something that then might have things re-adjusted in it.

@planctus planctus removed the Question label Sep 9, 2024
@planctus planctus changed the title fix(mega-menu): Showing the panels only when ready - FRONT-4606 fix(mega-menu): Showing the panels only when ready - FRONT-4604 Sep 9, 2024
@github-actions github-actions bot temporarily deployed to pull request September 9, 2024 13:08 Inactive
@planctus planctus merged commit f1c53cb into v4.6.4-dev Sep 12, 2024
7 checks passed
@planctus planctus deleted the FRONT-4606-Mega-menu-glitch-fix branch September 12, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants