feat(page-header): transparent background on EC - FRONT-4361 #3642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i guess we are doing this not because anyone requested it but because the designers wanted to add another potentially breaking change. Am i correct? :) |
|
not really a breaking change this time, they expect to have a slightly different color for page background, so it became visible that some component did not handle that correctly |
|
i said potentially breaking because we are making transparent something that was not, who knows if someone has some background there that might not cope well with the text color of the page header, hopefully no one did, but the risk is there. |
planctus
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove white background on EC page header