Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(margin): add responsive utilities - INNO-911 #556

Merged
merged 2 commits into from
Feb 1, 2018

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Jan 31, 2018

PR description

Add responsive utilities for margins.

QA Checklist

In order to ensure a safe and quick review, please check that your PR follow those guidelines:

  • package.json is up-to-date and @ec-europa/ecl-base is part of the dependencies
  • I have checked the dependencies
  • I have given the fractal status “ready” to my component
  • I have declared @define mycomponent in the SCSS file
  • I have specified margin: 0; on the CSS component
  • I have provided tests
  • I follow the naming guidelines
  • the component supports composition
  • there are no hardcoded strings (all content come from the context)
  • I have filled the README.md file (at least a few lines)
  • My component is listed in the root README
  • My PR has the right label(s)

@HAL-Patch-INNO
Copy link
Contributor

HAL-Patch-INNO commented Jan 31, 2018

Deploy preview for europa-component-library ready!

Built with commit fb3b74c

https://deploy-preview-556--europa-component-library.netlify.com

@emeryro emeryro assigned emeryro and unassigned emeryro Jan 31, 2018
@emeryro emeryro requested a review from a team February 1, 2018 07:59
@yhuard yhuard merged commit 1c4fe40 into master Feb 1, 2018
@yhuard yhuard deleted the feat/margin-INNO-908 branch February 1, 2018 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants