Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(links): fix link colours - INNO-866 #557

Merged
merged 11 commits into from
Feb 6, 2018
Merged

Conversation

raduchiriac
Copy link
Contributor

@raduchiriac raduchiriac commented Feb 2, 2018

PR description

Please drop a few lines about the PR: what it does, how to test it, etc.

QA Checklist

In order to ensure a safe and quick review, please check that your PR follow those guidelines:

  • package.json is up-to-date and @ec-europa/ecl-base is part of the dependencies
  • I have checked the dependencies
  • I have given the fractal status “ready” to my component
  • I have declared @define mycomponent in the SCSS file
  • I have specified margin: 0; on the CSS component
  • I have provided tests
  • I follow the naming guidelines
  • the component supports composition
  • there are no hardcoded strings (all content come from the context)
  • I have filled the README.md file (at least a few lines)
  • My component is listed in the root README
  • My PR has the right label(s)

@HAL-Patch-INNO
Copy link
Contributor

HAL-Patch-INNO commented Feb 2, 2018

Deploy preview for europa-component-library ready!

Built with commit 1df1f01

https://deploy-preview-557--europa-component-library.netlify.com

@yhuard yhuard changed the title fix(links): colours - INNO-866 fix(links): fix link colours - INNO-866 Feb 2, 2018
@yhuard
Copy link
Contributor

yhuard commented Feb 5, 2018

@raduchiriac please update inpage navigation and list-items's screenshots as well :)

@yhuard yhuard merged commit c674efd into master Feb 6, 2018
@yhuard yhuard deleted the fix/link-colours-INNO-866 branch February 6, 2018 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants