fix(listing): remove extra padding - INNO-916 #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for europa-component-library ready! Built with commit 29534d5 https://deploy-preview-686--europa-component-library.netlify.com |
kalinchernev
reviewed
May 7, 2018
| @@ -31,8 +31,12 @@ | |||
| width: 50%; | |||
| } | |||
|
|
|||
| .ecl-list-item__link { | |||
| .ecl-list-item:nth-child(2n + 0) .ecl-list-item__link { | |||
There was a problem hiding this comment.
To be honest, it's easy to understand what's going on here without reading aside. A comment or two what are these calculations meant to represent will be helpful. There's also the nth-of-type(odd) and nth-of-type(even) syntax which makes it a bit more obvious without the calculations.
| @@ -57,10 +61,18 @@ | |||
| width: 33%; | |||
| } | |||
|
|
|||
| .ecl-list-item__link { | |||
| .ecl-list-item:nth-child(3n + 0) .ecl-list-item__link { | |||
There was a problem hiding this comment.
Some documentation here will also be useful :)
kalinchernev
approved these changes
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fix horizontal alignment
QA Checklist
In order to ensure a safe and quick review, please check that your PR follow those guidelines:
package.jsonis up-to-date and@ecl/[system]-baseis part of the dependencies@define mycomponentin the SCSS filemargin: 0;on the CSS component