Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(breadcrumb): update breadcrumb and logo - INNO-1079 #694

Merged
merged 8 commits into from
May 29, 2018
Merged

fix(breadcrumb): update breadcrumb and logo - INNO-1079 #694

merged 8 commits into from
May 29, 2018

Conversation

raduchiriac
Copy link
Contributor

@raduchiriac raduchiriac commented May 25, 2018 •
edited
Loading

PR description

  • in all the demos and in the style guide itself, replace "European Commission" by "Home"
  • in the demos using the logo component, make sure the demo has a language set

QA Checklist

In order to ensure a safe and quick review, please check that your PR follow those guidelines:

  • package.json is up-to-date and @ecl/[system]-base is part of the dependencies
  • I have checked the dependencies
  • I have given the fractal status “ready” to my component
  • I have declared @define mycomponent in the SCSS file
  • I have specified margin: 0; on the CSS component
  • I have provided tests
  • I follow the naming guidelines
  • the component supports composition
  • there are no hardcoded strings (all content come from the context)
  • I have filled the README.md file (at least a few lines)
  • My component is listed in the root README
  • My PR has the right label(s)

@raduchiriac raduchiriac self-assigned this May 25, 2018
@HAL-Patch-INNO
Copy link
Contributor

HAL-Patch-INNO commented May 25, 2018 •
edited
Loading

Deploy preview for europa-component-library ready!

Built with commit e3bbbd6

https://deploy-preview-694--europa-component-library.netlify.com

@raduchiriac raduchiriac requested a review from a team May 28, 2018 11:04
@raduchiriac raduchiriac removed their assignment May 28, 2018
@yhuard yhuard self-assigned this May 28, 2018
yhuard
yhuard suggested changes May 28, 2018
View reviewed changes
Copy link
Contributor

@yhuard yhuard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update:

  • ec-component-site-header (the logo is missing the language)
  • [ec/eu]-template-community: still "European Commission" instead of "Home"

@yhuard yhuard removed their assignment May 28, 2018
@raduchiriac raduchiriac self-assigned this May 28, 2018
@raduchiriac raduchiriac removed their assignment May 28, 2018
@yhuard yhuard merged commit f9facd9 into master May 29, 2018
@yhuard yhuard deleted the fix/update-breadcrumb-and-logo-INNO-1079 branch May 29, 2018 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhuard yhuard yhuard approved these changes

Assignees
No one assigned
Labels
tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raduchiriac @HAL-Patch-INNO @yhuard