Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(breadcrumb): add "expand all" behavior - INNO-1104 #716

Merged
merged 1 commit into from
Jul 2, 2018

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Jul 2, 2018

PR description

Add missing behavior when expanding the breadcrumb all at once

To test:

  • display the breadcrumb collapsed (on small window)
  • maximize the window or quickly resize it at maximum
    -> breadcrumb is fully expanded

QA Checklist

In order to ensure a safe and quick review, please check that your PR follow those guidelines:

  • package.json is up-to-date and @ecl/[system]-base is part of the dependencies
  • I have checked the dependencies
  • I have given the fractal status “ready” to my component
  • I have declared @define mycomponent in the SCSS file
  • I have specified margin: 0; on the CSS component
  • I have provided tests
  • I follow the naming guidelines
  • the component supports composition
  • there are no hardcoded strings (all content come from the context)
  • I have filled the README.md file (at least a few lines)
  • My component is listed in the root README
  • My PR has the right label(s)

@HAL-Patch-INNO
Copy link
Contributor

Deploy preview for europa-component-library ready!

Built with commit dc53cab

https://deploy-preview-716--europa-component-library.netlify.com

@yhuard yhuard merged commit f16971d into master Jul 2, 2018
@yhuard yhuard deleted the fix/breadcrumb-expand-all-INNO-1104 branch July 2, 2018 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants