feat(eu-header): apply new specs - INNO-1203 #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for europa-component-library ready! Built with commit e7a1f91 https://deploy-preview-811--europa-component-library.netlify.com |
yhuard
suggested changes
Sep 12, 2018
|
|
||
| <SearchForm | ||
| className="ecl-site-header__search" | ||
| buttonLabel={searchForm.buttonLabel} |
| className="ecl-site-header__logo ecl-link ecl-link--standalone" | ||
| href={logo.href} | ||
| > | ||
| <Logo title={logo.title} alt={logo.alt} language={logo.language} /> |
There was a problem hiding this comment.
why not <Logo {...logo} />?
| }); | ||
|
|
||
| return ( | ||
| <div className={classNames} {...props}> |
There was a problem hiding this comment.
why not use <header>? and role="banner"?
https://www.w3.org/TR/wai-aria-practices-1.1/examples/landmarks/banner.html
https://www.scottohara.me/blog/2018/03/03/landmarks.html
There was a problem hiding this comment.
role="banner" is reported as an error by a11y, but indeed it should be header and not div
| </a> | ||
|
|
||
| <div className="ecl-site-header__selector"> | ||
| <a |
There was a problem hiding this comment.
because Link do not allow anything else from simple text for now
yhuard
previously requested changes
Sep 12, 2018
| @@ -25,8 +25,8 @@ const SearchForm = ({ textInputId, buttonLabel, className, ...props }) => { | |||
| }; | |||
|
|
|||
| return ( | |||
| <form {...props} className={classNames}> | |||
| <TextInput {...searchTextInput} /> | |||
| <form {...props} className={classNames} role="search"> | |||
There was a problem hiding this comment.
Can you update the EC version as well? :)
degliwe
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Apply specifications of eu header
Also contains language selector
Note that language selector is just a link for now.
Overlay will be added once language list has been done (INNO-1186)