Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement in Resource.Builder#mergeResources #4300

Merged
merged 2 commits into from
Nov 20, 2019

Conversation

jansupol
Copy link
Contributor

Signed-off-by: Jan Supol jan.supol@oracle.com

@jansupol
Copy link
Contributor Author

An alternative to #4297

Copy link
Contributor

@senivam senivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's perfect alternative, however I would advise to take it from the actual master. Rebase master onto your branch. Since mine is already merged so I'm not sure if it would revert LinkedList back onto ArrayList.

Signed-off-by: Jan Supol <jan.supol@oracle.com>
@jansupol
Copy link
Contributor Author

Rebased on top of the master

@senivam
Copy link
Contributor

senivam commented Oct 28, 2019

this line:
this.childResources = new ArrayList<>();
shall be reverted to LinkedList if I understand correctly...

Signed-off-by: Jan Supol <jan.supol@oracle.com>
@jansupol jansupol merged commit b86c80e into eclipse-ee4j:master Nov 20, 2019
@jansupol jansupol deleted the resource_perf branch November 20, 2019 09:49
@jansupol jansupol added this to the 2.30 milestone Nov 20, 2019
@jansupol jansupol self-assigned this Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants