Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides an early preview of the Jetty 12 upgrade with Jetty 12.0.0.beta1.
Jersey 3.1.x currently has compatibility issues with Jetty. Jersey 3.1 is compatible with Jakarta EE 10 and therefore uses
servlet-api
6. But the current Jetty version 11.0.x isn't compatible withservlet-api
6.Although the upgrade to Jetty 12 is a major upgrade, this can be released for the servlet compatibility in Jersey 3.1.x IMHO.
Notable changes:
servlet-api
isn't integrated into Jetty's core classes any more and rather moved out to a separate module. For servlet classes the correct servlet module has to be included (e.g.jetty-ee10-servlet
for Jersey 3.1).The
JettyHttpContainer
is rewritten by removing all servlet related classes. This prevents incompatibilities with future servlet versions.Handler
interface has changed and now uses aCallback
class to signal output completion. Thehandled
state is set with the method's return value.JettyHttpContainer
: TheSecurityContext
is set via theAuthenticationState
. In the current implementation noSecurityHandler
is provided and therefore theAuthenticationState
will always benull
. Maybe theJettyHttpContainer
should implement theHandler.Singleton
interface to let users specify aSecurityHandler
.