[WIP] Run tests against javac bits #3167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
force-pushed
the
javac-poc-tests
branch
3 times, most recently
from
046db5d
to
db2819f
Compare
|
I got the tests running in https://ci.eclipse.org/ls/job/jdt-ls-javac/ |
fbricon
force-pushed
the
javac-poc-tests
branch
4 times, most recently
from
ea04e38
to
46fe57f
Compare
fbricon
force-pushed
the
javac-poc-tests
branch
2 times, most recently
from
182472f
to
7ff2b84
Compare
Comment on lines
+8
to
+11
| Bundle-RequiredExecutionEnvironment: JavaSE-23 | ||
| Import-Package: org.osgi.framework;version="1.3.0", | ||
| org.eclipse.jdt.internal.javac, | ||
| org.eclipse.jdt.internal.javac.dom |
There was a problem hiding this comment.
Instead of tweaking the MANIFEST.MF, you can consider adding the javac bundle as extraRequirement with target-platform-configuration block in the pom.xml. This bit of customization could also be encapsulated in the javac profile, so it can be easier to merge later.
fbricon
force-pushed
the
javac-poc-tests
branch
from
7ff2b84
to
72443c7
Compare
This was referenced Aug 30, 2024
pom.xml
Outdated
| <profile> | ||
| <id>javac</id> | ||
| <properties> | ||
| <tycho.testArgLine>--add-opens jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED --add-opens jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED --add-opens jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-opens jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED --add-opens jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED --add-opens jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED --add-opens jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED -DICompilationUnitResolver=org.eclipse.jdt.core.dom.JavacCompilationUnitResolver -DCompilationUnit.DOM_BASED_OPERATIONS=true -DAbstractImageBuilder.compiler=org.eclipse.jdt.internal.javac.JavacCompiler</tycho.testArgLine> |
There was a problem hiding this comment.
This now also needs
--add-opens jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.taglets.snippet=ALL-UNNAMED --add-opens jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.taglets=ALL-UNNAMED
Comment on lines
+24
to
+43
| <compilerArgs combine.self="override"> | ||
| <arg>--add-exports</arg> | ||
| <arg>java.base/java.lang=ALL-UNNAMED</arg> | ||
| <arg>--add-exports</arg> | ||
| <arg>jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED</arg> | ||
| <arg>--add-exports</arg> | ||
| <arg>jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED</arg> | ||
| <arg>--add-exports</arg> | ||
| <arg>jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED</arg> | ||
| <arg>--add-exports</arg> | ||
| <arg>jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED</arg> | ||
| <arg>--add-exports</arg> | ||
| <arg>jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED</arg> | ||
| <arg>--add-exports</arg> | ||
| <arg>jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED</arg> | ||
| <arg>--add-exports</arg> | ||
| <arg>jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED</arg> | ||
| <arg>--add-exports</arg> | ||
| <arg>jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED</arg> | ||
| </compilerArgs> |
There was a problem hiding this comment.
This might possibly be removed
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon
force-pushed
the
javac-poc-tests
branch
from
72443c7
to
b2bc078
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to run
But for some reason I run into:
@akurtakov @mickaelistria what am I missing?