Close button on electron build does not work

[dmm9]

The close (X) button does not have any effect on electron build on Windows - using Theia 1.49.1, node 20, windows. The only way to quit is by killing the process in the task manager. Is this a bug or a wrong configuration on my side?

[msujew]

Hey @dmm9,

do you mean an electron build of your custom IDE? I cannot reproduce this using the example app in this repo or the Theia IDE. Can you reproduce the issue using the Theia IDE app?

[dmm9]

Yes, I am building my custom IDE. The (X) works if I download the prebuilt installer or if I build the blueprint repo (latest version as of today)

By the way, the splash screen is smaller than the image, so a scroll bar appears. But that's another topic.

[dmm9]

@msujew Any ideas where can I look into? Unfortunately, I am not experienced with electron..

[msujew]

No idea, maybe you can provide a reproducible example? Sounds like a pretty unique problem. Maybe @tsmaeder knows more.

[tsmaeder]

The close button works on the electron example in main. I guess the simplest way would be to debug through the code that handles the close event from the electron BrowserWindow in theia-electron-window.ts. The "Launch Electron Back End" debug configuration from the theia repo should work (with changes for your concrete case) in your project as well.

[dmm9]

Thank you @tsmaeder . I have just revisited this issue (couldn't do this before for other reasons), and I have quickly found the mistake by creating (copying) the debug configuration. It has been straightforward.

I could see the debug message Shutdown prevented by No reason given when clicking on the (X) button, which was caused by a frontend contribution with OnWillStop always returning true.