-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to use Language Configurations and gramars from TM4E Language … #1252
Switch to use Language Configurations and gramars from TM4E Language … #1252
Conversation
XML Language Configs and Grammars aren't supported in current TM4E Language Pack (0.7.1) JavaScriptReact (JSX) Syntax Highlighting works, however |
Would it be possible to switch to the latest tm4e release even before this greater rework, so that downstream consumers like m2e could use it with the latest snakeyaml? |
@HannesWell I haven't tested yet, but without switching to use tm4e language pack provided schemas there is no need to drag (require) |
It's just that switching to tm4e language_pack would be welcomed, but currently not all the editors can work well with its schemes as well as not all the required scheames are included to tm4e.language_pack, so we cannot switch fully to use tm4e LP at the moment. |
It is not urgent. Mainly I was going through m2e's target-platform and noticed that it is not using the latest tm4e dependencies and therefore snakeyaml 1 (which is from Orbit and not Maven-Central, which is why this often needs extra care). Btw. I was told for m2e that it is not recommended for projects that participate in the SimRel to use the SimRel repository in their TP because one is basically forming a cycle. I just noticed it is used here and wanted to mention that. |
Currently, when WWD target platform is built it takes tm4e from https://download.eclipse.org/releases/latest/ - but there is no any tm4e language pack provided. So in this PR I've switched to directly use tm4e repository (https://download.eclipse.org/tm4e/releases/latest/).
m2e-core depends on:
WWD demends on:
I see no problem nor a cycle dependency possibility here. Do you see any problem? |
It was more a suggestion because I assume it would be simpler to accomplish than this entire rework and therefore the latest tm4e can be used earlier.
This was more meant in general if a project that contributes to https://download.eclipse.org/releases/ also uses https://download.eclipse.org/releases/ in its TP, the SimRel repo depends on itself respectively its older versions and it could happen that it contains artifacts that are actually not build anymore and were just bootstrapped via previous releases. |
I've split the tm4e dependency to be downloaded from the tm4e repository (instead of Eclipse Releases) out of this PR. This makes WWD to use the latest released tm4e version and gives access to tm4e Language Pack bundle: #1317 |
Great! Thank you. :) |
…Pack