Add discoverability feature to kuksa.val.v1 API #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argerus
changed the title
rafaeling
force-pushed
the
feature/add_discoverability_to_databroker
branch
from
91bcc29
to
c56e934
Compare
argerus
requested changes
Aug 24, 2023
argerus
force-pushed
the
feature/add_discoverability_to_databroker
branch
from
f5cdeea
to
d7499a5
Compare
argerus
requested changes
Sep 5, 2023
Comment on lines
170
to
172
| Err(_error) => { | ||
| println!("Error: Invalid Regex"); | ||
| } |
There was a problem hiding this comment.
You are right, should not return anything
argerus
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that implements the following examples table for discoverability feature.