AArch64: Handle shift amount 0 #7343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code fixes shiftHelper() in AArch64 codegen. It generates a mov instruction when the shift amount is 0 and the reference count of the first child of a shift node is larger than 1. Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
|
Jenkins build aarch64,amac |
|
This is a fix for eclipse-openj9/openj9#19525. |
0xdaryl
approved these changes
May 23, 2024
knn-k
added a commit
to knn-k/openj9-omr
that referenced
this pull request
May 23, 2024
This code fixes shiftHelper() in AArch64 codegen. It generates a mov instruction when the shift amount is 0 and the reference count of the first child of a shift node is larger than 1. Original PR: eclipse/omr#7343 Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code fixes shiftHelper() in AArch64 codegen.
It generates a mov instruction when the shift amount is 0 and the reference count of the first child of a shift node is larger than 1.