Disable TLH prefetching by default post-Skylake processors #7357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
0xdaryl
commented
Jun 3, 2024
0xdaryl
commented
- Remove deprecated processor enum values
- Eliminate targetSupportsSoftwarePrefetches flag
- Disable TLH allocation prefetching by default post-Skylake
All known uses in downstream projects have been changed. Signed-off-by: Daryl Maier <maier@ca.ibm.com>
This flag was always set to true and all supported target x86 processors support prefetch instructions. This flag is unnecessary. Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
|
Jenkins build all |
|
@BradleyWood your review would be appreciated here. Thanks |
vijaysun-omr
approved these changes
Jun 4, 2024
BradleyWood
approved these changes
Jun 5, 2024
|
Checks have passed, and it is a simple change that is now approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.