Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AArch64: Improve *cmpeq-*select instruction sequence #7361

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Jun 5, 2024

This commit improves the instruction sequence for *select nodes with a *cmpeq node as the first child.

This commit improves the instruction sequence for *select nodes with a
*cmpeq node as the first child.

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
@knn-k
Copy link
Contributor Author

knn-k commented Jun 5, 2024

Jenkins build aarch64,amac

@knn-k
Copy link
Contributor Author

knn-k commented Jun 6, 2024

See #5450 (comment) for the background of this change.
I ran OpenJ9 sanity.functional on AArch64 macOS with this change, and got no failures.

@knn-k knn-k marked this pull request as ready for review June 6, 2024 07:01
@knn-k knn-k requested a review from 0xdaryl as a code owner June 6, 2024 07:01
@0xdaryl 0xdaryl merged commit a3ad1c5 into eclipse:master Jun 6, 2024
8 checks passed
@knn-k knn-k deleted the aarch64cmpeqSelect branch June 6, 2024 23:29
knn-k added a commit to knn-k/omr that referenced this pull request Jun 11, 2024
This is a follow-up of PR eclipse#7361, adding support for select nodes with
other kinds of cmp nodes as the first child, such as icmpne and acmpgt.

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
knn-k added a commit to knn-k/omr that referenced this pull request Jun 12, 2024
This is a follow-up of PR eclipse#7361, adding support for select nodes with
other kinds of cmp nodes as the first child, such as icmpne and acmpgt.

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
knn-k added a commit to knn-k/omr that referenced this pull request Jun 12, 2024
This is a follow-up of PR eclipse#7361, adding support for select nodes with
other kinds of cmp nodes as the first child, such as icmpne and acmpgt.

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants