Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x86-64: Use rep movs instructions if array copy size greater than 32 bytes #7384

Conversation

a7ehuo
Copy link
Contributor

@a7ehuo a7ehuo commented Jun 18, 2024

This change applies to byte and char array System.arraycopy sequence.

It avoids using vector instructions for copy size between 32 bytes to 64 bytes due to an observed regression.

@a7ehuo a7ehuo removed the request for review from mstoodle June 18, 2024 00:53
@a7ehuo
Copy link
Contributor Author

a7ehuo commented Jun 18, 2024

@0xdaryl May I ask you to review this change? Thank you!

@vijaysun-omr @ymanton @hzongaro

Copy link
Contributor

@0xdaryl 0xdaryl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments only.

compiler/x/codegen/OMRTreeEvaluator.cpp Outdated Show resolved Hide resolved
compiler/x/codegen/OMRTreeEvaluator.cpp Outdated Show resolved Hide resolved
compiler/x/codegen/OMRTreeEvaluator.cpp Outdated Show resolved Hide resolved
compiler/x/codegen/OMRTreeEvaluator.cpp Outdated Show resolved Hide resolved
compiler/x/codegen/OMRTreeEvaluator.cpp Outdated Show resolved Hide resolved
compiler/x/codegen/OMRTreeEvaluator.cpp Outdated Show resolved Hide resolved
compiler/x/codegen/OMRTreeEvaluator.cpp Outdated Show resolved Hide resolved
…bytes

This change applies to byte and char array System.arraycopy
sequence. It avoids using vector instructions for copy
size between 32 bytes to 64 bytes due to an observed regression.

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo a7ehuo force-pushed the system-arraycopy-perf-13-byte-char-threshold-32bytes branch from 3b81ee0 to 8aa9487 Compare June 18, 2024 16:20
@a7ehuo
Copy link
Contributor Author

a7ehuo commented Jun 18, 2024

@0xdaryl All comments are addressed in Addressed in 8aa9487. Ready for another review. Thank you!

@0xdaryl
Copy link
Contributor

0xdaryl commented Jun 18, 2024

Jenkins build xlinux,win,x32linux

@0xdaryl 0xdaryl merged commit 7709363 into eclipse:master Jun 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants