New element is added in vgc:mem-info #7386
Conversation
|
@dmitripivkine @amicic please review the changes, Thanks |
gc/verbose/schema.xsd
Outdated
| @@ -452,6 +454,11 @@ xmlns:vgc="http://www.ibm.com/j9/verbosegc"> | |||
| <attribute name="classloader" type="integer" use="required" /> | |||
| </complexType> | |||
|
|
|||
| <complexType name="continuation-objects"> | |||
| <attribute name="alive" type="integer" use="required" /> | |||
There was a problem hiding this comment.
it's almost given that we are talking about live ones (especially since this will be at the end of GC)
perhaps simpler is just 'total'
@dmitripivkine, opinion?
There was a problem hiding this comment.
Update the comment, too. Still refers to 'alive'.
new element "vgc:continuation-objects" is added in vgc:mem-info, the element with two integer addributes "total" and "started" Signed-off-by: hulin <linhu@ca.ibm.com>
LinHu2016
force-pushed
the
livecontinuationInVerbosegc
branch
from
40b2f62
to
32aabf4
Compare
| @@ -452,6 +454,11 @@ xmlns:vgc="http://www.ibm.com/j9/verbosegc"> | |||
| <attribute name="classloader" type="integer" use="required" /> | |||
| </complexType> | |||
|
|
|||
| <complexType name="continuation-objects"> | |||
| <attribute name="total" type="integer" use="required" /> | |||
| <attribute name="started" type="integer" use="required" /> | |||
There was a problem hiding this comment.
started probably means only active (thus excluding those not only started by also ended).
not sure if active is the right term though (as per specs)
@babsingh @fengxue-IS, are you ok with 'started' or have some other preference?
There was a problem hiding this comment.
Yes. In the context of Continuations, STARTED looks good; it corresponds to the Continuation state where a stack is always populated.
|
@babsingh please, proceed with the final review |
|
jenkins build all |
|
just a frendly reminder - the testing finished |
new element "vgc:continuation-objects" is added in vgc:mem-info,
the element with two integer addributes "total" and "started"
Signed-off-by: hulin linhu@ca.ibm.com