Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more info to CodeCache::printOccupancyStats() #7401

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

mpirvu
Copy link
Contributor

@mpirvu mpirvu commented Jul 9, 2024

OMR::CodeCache::printOccupancyStats() prints to stderr various information about the code cache usage such as:

  • Whether it's full or not
  • The values for the warmCodeAlloc and coldCodeAlloc pointers
  • How much space is available in the hole between warmCodeAlloc and coldCodeAlloc
  • The list of freed blocks that are available for reuse

This commit adds a new line of output that shows the sizes of warm and cold sections of the code cache.

@mpirvu mpirvu requested a review from dsouzai as a code owner July 9, 2024 19:12
OMR::CodeCache::printOccupancyStats() prints to stderr
various information about the code cache usage such as:
- Whether it's full or not
- The values for the warmCodeAlloc and coldCodeAlloc pointers
- How much space is available in the hole between warmCodeAlloc and coldCodeAlloc
- The list of freed blocks that are available for reuse

This commit adds a new line of output that shows the sizes of
warm and cold sections of the code cache.

Signed-off-by: Marius <mpirvu@ca.ibm.com>
@dsouzai
Copy link
Member

dsouzai commented Jul 9, 2024

jenkins build all

@dsouzai dsouzai self-assigned this Jul 9, 2024
@dsouzai
Copy link
Member

dsouzai commented Jul 9, 2024

plinux test failed bcause of

15:43:40  31: free(): invalid next size (normal)
15:43:40  31/31 Test #31: compunittest ......................Child aborted***Exception:   0.76 sec
15:43:40  
15:43:40  97% tests passed, 1 tests failed out of 31
15:43:40  
15:43:40  Total Test time (real) = 482.26 sec
15:43:40  
15:43:40  The following tests FAILED:
15:43:40  	 31 - compunittest (Child aborted)
15:43:40  Errors while running CTest

I don't see an existing open issue for this, but I don't see how the changes in this PR could cause this. Will rerun.

@dsouzai
Copy link
Member

dsouzai commented Jul 9, 2024

jenkins build plinux

@dsouzai
Copy link
Member

dsouzai commented Jul 10, 2024

plinux build error seen in the PR build of #7400, so will merge.

@dsouzai dsouzai merged commit 5e425eb into eclipse:master Jul 10, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants