Tweak build for QIREE (downstream) #587
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on linking Qwerty with QIREE, but
QIREEConfig.cmake
attempts tofind_package(XACC 1.0.0)
, which is not valid unless there is axacc-config-version.cmake
, which this PR adds. Yes we could tweak QIREE's configuration not to do that, but I think this is a valid usecase for software downstream of XACC.This PR also avoids installing gtest if tests are not being built. If ORNL folks point cmake to
$XACC_DIR
to find gtest when building QIREE (I have no clue if so), then this is a breaking change. (However, I don't thinkmake install
for any software package should install the unit testing framework it uses, in my opinion. Imagine how many different versions of unit testing libraries you'd have in/usr/lib
if that were common practice.)