Set cluster-settings via API #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we avoid the soon to be deprecated track property `cluster-settings` in the `pmc` track and instead implement a fallback using the update cluster settings API. Newer versions of Rally will expose this API via a runner but for older versions we need to implement it in the track.
danielmitterdorfer
added a commit
to danielmitterdorfer/rally
that referenced
this pull request
Nov 29, 2019
With this commit we introduce a new `put-settings` operation that can be used to update cluster settings via the REST API. We also deprecate the track property `cluster-settings` which had a similar purpose but the cluster settings ended up in `elasticsearch.yml` instead of being updated via an API. This is now tricky as we will move away from an integrated cluster management (see also elastic#830) and we should instead add settings that need to be persistent in `elasticsearch.yml` via `--car-params` and settings that are per track via the cluster settings API. Relates elastic/rally-tracks#93
|
Thanks for the review! |
danielmitterdorfer
added a commit
to elastic/rally
that referenced
this pull request
Dec 4, 2019
With this commit we introduce a new `put-settings` operation that can be used to update cluster settings via the REST API. We also deprecate the track property `cluster-settings` which had a similar purpose but the cluster settings ended up in `elasticsearch.yml` instead of being updated via an API. This is now tricky as we will move away from an integrated cluster management (see also #830) and we should instead add settings that need to be persistent in `elasticsearch.yml` via `--car-params` and settings that are per track via the cluster settings API. Relates elastic/rally-tracks#93 Relates #831
danielmitterdorfer
added a commit
that referenced
this pull request
Dec 4, 2019
With this commit we avoid the soon to be deprecated track property `cluster-settings` in the `pmc` track and instead implement a fallback using the update cluster settings API. Newer versions of Rally will expose this API via a runner but for older versions we need to implement it in the track. Relates #93
danielmitterdorfer
added a commit
that referenced
this pull request
Dec 4, 2019
With this commit we avoid the soon to be deprecated track property `cluster-settings` in the `pmc` track and instead implement a fallback using the update cluster settings API. Newer versions of Rally will expose this API via a runner but for older versions we need to implement it in the track. Relates #93
danielmitterdorfer
added a commit
that referenced
this pull request
Dec 4, 2019
With this commit we avoid the soon to be deprecated track property `cluster-settings` in the `pmc` track and instead implement a fallback using the update cluster settings API. Newer versions of Rally will expose this API via a runner but for older versions we need to implement it in the track. Relates #93
danielmitterdorfer
added a commit
that referenced
this pull request
Dec 4, 2019
With this commit we avoid the soon to be deprecated track property `cluster-settings` in the `pmc` track and instead implement a fallback using the update cluster settings API. Newer versions of Rally will expose this API via a runner but for older versions we need to implement it in the track. Relates #93
danielmitterdorfer
added a commit
that referenced
this pull request
Dec 4, 2019
With this commit we avoid the soon to be deprecated track property `cluster-settings` in the `pmc` track and instead implement a fallback using the update cluster settings API. Newer versions of Rally will expose this API via a runner but for older versions we need to implement it in the track. Relates #93
danielmitterdorfer
added a commit
that referenced
this pull request
Dec 4, 2019
With this commit we avoid the soon to be deprecated track property `cluster-settings` in the `pmc` track and instead implement a fallback using the update cluster settings API. Newer versions of Rally will expose this API via a runner but for older versions we need to implement it in the track. Relates #93
danielmitterdorfer
added a commit
to danielmitterdorfer/rally-tracks
that referenced
this pull request
Feb 21, 2020
With this commit we avoid the deprecated track property `cluster-settings` and replace it with an explicit API call. Relates elastic#93 Relates elastic/rally#831 Relates elastic/rally#915
danielmitterdorfer
added a commit
that referenced
this pull request
Feb 21, 2020
With this commit we avoid the deprecated track property `cluster-settings` and replace it with an explicit API call. Relates #93 Relates elastic/rally#831 Relates elastic/rally#915
danielmitterdorfer
added a commit
that referenced
this pull request
Feb 21, 2020
With this commit we avoid the deprecated track property `cluster-settings` and replace it with an explicit API call. Relates #93 Relates elastic/rally#831 Relates elastic/rally#915
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we avoid the soon to be deprecated track property
cluster-settingsin thepmctrack and instead implement a fallbackusing the update cluster settings API. Newer versions of Rally will
expose this API via a runner but for older versions we need to implement
it in the track.