Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require JDK 9 for source builds #387

Closed
danielmitterdorfer opened this issue Jan 5, 2018 · 0 comments
Closed

Require JDK 9 for source builds #387

danielmitterdorfer opened this issue Jan 5, 2018 · 0 comments
Labels
:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch enhancement Improves the status quo
Milestone

Comments

@danielmitterdorfer
Copy link
Member

When elastic/elasticsearch#28071 is merged, source builds of Elasticsearch master will require Java 9. Hence, we need to add check for a Java 9 installation / ask the user and set it when users want to build Elasticsearch from sources.

@danielmitterdorfer danielmitterdorfer added :Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch enhancement Improves the status quo labels Jan 5, 2018
@danielmitterdorfer danielmitterdorfer added this to the 0.9.0 milestone Jan 5, 2018
dliappis added a commit to dliappis/rally that referenced this issue Mar 27, 2018
Similar to the work done for elastic#387, following the merge of the
Elasticsearch PR[1], Rally needs to require java-10 to build
Elasticsearch from source.

Bump the configuration version to 14 and adjust migration of existing
configs to support building with java-10. Also add needed test cases.

Note that building from source with java-10 requires, at minimum,
gradle 4.5[2]. This helps us remove a number of additional gradle
options that were needed for java-9. So for now, building will fail
with gradle <4.5, which will won't be a worry at all once we start
using `./gradlew`; this is tracked in issue#412.

Closes elastic#450

[1] elastic/elasticsearch#29174
[2] gradle/gradle#3892
dliappis added a commit to dliappis/rally that referenced this issue Mar 27, 2018
Similar to the work done for elastic#387, following the merge of the
Elasticsearch PR[1], Rally needs to require java-10 to build
Elasticsearch from source.

Bump the configuration version to 14 and adjust migration of existing
configs to support building with java-10. Also add needed test cases
and update docs.

Note that building from source with java-10 requires, at minimum,
gradle 4.5[2]. This helps us remove a number of additional gradle
options that were needed for java-9. So for now, building will fail
with gradle <4.5, which will won't be a worry at all once we start
using `./gradlew`; this is tracked in issue#412.

Closes elastic#450

[1] elastic/elasticsearch#29174
[2] gradle/gradle#3892
dliappis added a commit that referenced this issue Mar 28, 2018
Similar to the work done for #387, following the merge of the
Elasticsearch PR[1], Rally needs to require java-10 to build
Elasticsearch from source.

Bump the configuration version to 14 and adjust migration of existing
configs to support building with java-10. Also add needed test cases
and update docs.

Note that building from source with java-10 requires, at minimum,
gradle 4.5[2]. This helps us remove a number of additional gradle
options that were needed for java-9. So for now, building will fail
with gradle <4.5, which will won't be a worry at all once we start
using `./gradlew`; this is tracked in issue#412.

Closes #450
Relates #451 

[1] elastic/elasticsearch#29174
[2] gradle/gradle#3892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch enhancement Improves the status quo
Projects
None yet
Development

No branches or pull requests

1 participant