-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust JDK detection / configuration #452
Labels
:Benchmark Candidate Management
Anything affecting how Rally sets up Elasticsearch
enhancement
Improves the status quo
Milestone
Comments
danielmitterdorfer
added
enhancement
Improves the status quo
:Config
Config file format changes, new properties, ...
labels
Apr 3, 2018
Merged
After discussion we settled on the following requirements:
We came up with the following approach:
As it is possible for users to define custom team repositories, we will issue a warning if |
We should leverage the mechanisms introduced in #485 and define new properties in |
danielmitterdorfer
added a commit
that referenced
this issue
Jun 5, 2018
With this commit we derive the appropriate JDK version at benchmark runtime instead of requiring that it is preconfigured. This requires two new variables in the rally-teams repo: `build.jdk` and `runtime.jdk` to resolve the appropriate (major) JDK version depending on the Elasticsearch version. When we know the required JDK version, we check the environment variables `JAVAx_HOME` (where `x` is the JDK version) and `JAVA_HOME` to find the correct JAVA_HOME path. We also allow the user to override the runtime JDK with a new command line parameter `--runtime-jdk` as Rally will default to the highest available and supported JDK version on the target system. Closes #452
danielmitterdorfer
added a commit
that referenced
this issue
Jun 5, 2018
With this commit we derive the appropriate JDK version at benchmark runtime instead of requiring that it is preconfigured. This requires two new variables in the rally-teams repo: `build.jdk` and `runtime.jdk` to resolve the appropriate (major) JDK version depending on the Elasticsearch version. When we know the required JDK version, we check the environment variables `JAVAx_HOME` (where `x` is the JDK version) and `JAVA_HOME` to find the correct JAVA_HOME path. We also allow the user to override the runtime JDK with a new command line parameter `--runtime-jdk` as Rally will default to the highest available and supported JDK version on the target system. Closes #452
danielmitterdorfer
added
:Benchmark Candidate Management
Anything affecting how Rally sets up Elasticsearch
and removed
:Config
Config file format changes, new properties, ...
labels
Jun 5, 2018
danielmitterdorfer
added a commit
to elastic/rally-teams
that referenced
this issue
Jun 5, 2018
danielmitterdorfer
added a commit
to elastic/rally-teams
that referenced
this issue
Jun 5, 2018
danielmitterdorfer
added a commit
to elastic/rally-teams
that referenced
this issue
Jun 5, 2018
danielmitterdorfer
added a commit
to elastic/rally-teams
that referenced
this issue
Jun 5, 2018
danielmitterdorfer
added a commit
to elastic/rally-teams
that referenced
this issue
Jun 5, 2018
danielmitterdorfer
added a commit
to elastic/rally-teams
that referenced
this issue
Jun 5, 2018
danielmitterdorfer
added a commit
to elastic/rally-teams
that referenced
this issue
Jun 5, 2018
danielmitterdorfer
added a commit
that referenced
this issue
Jun 14, 2018
With this commit we derive the appropriate JDK version at benchmark runtime instead of requiring that it is preconfigured. This requires two new variables in the rally-teams repo: `build.jdk` and `runtime.jdk` to resolve the appropriate (major) JDK version depending on the Elasticsearch version. When we know the required JDK version, we check the environment variables `JAVAx_HOME` (where `x` is the JDK version) and `JAVA_HOME` to find the correct JAVA_HOME path. We also allow the user to override the runtime JDK with a new command line parameter `--runtime-jdk` as Rally will default to the highest available and supported JDK version on the target system. Closes #452 Relates #518
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Benchmark Candidate Management
Anything affecting how Rally sets up Elasticsearch
enhancement
Improves the status quo
Rally has been created before the JDK moved to a more rapid 6 month release cycle. However, meanwhile things have changed and Elasticsearch embraces this more rapid cycle. Elasticsearch allows us to set:
RUNTIME_JAVA_HOME
to define the JDK version that Elasticsearch will run with, andJAVA_HOME
to define the JDK version that Elasticsearch is built with (will also be used ifRUNTIME_JAVA_HOME
is not set)Our current configuration logic in Rally however, is still tied to specific JDK versions and we should change that. Ideally we can still figure out everything automatically for the standard case but the exact logic is yet tbd.
W.r.t. to the timeframe it would be good if we could implement this before JDK 11 is out.
The text was updated successfully, but these errors were encountered: