Wait until indices are green in generated track #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the track generated by the `create-track` sub-command starts bulk indexing immediately after creating indices. This may affect benchmarking results as starting indexing when indices are still yellow may result in unwanted peer-recovery during indexing. Wait that all indices are green before indexing in generated tracks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the track generated by the
create-tracksub-command startsbulk indexing immediately after creating indices.
This may affect benchmarking results as starting indexing when indices
are still yellow may result in unwanted peer-recovery during indexing.
Wait that all indices are green before indexing in generated tracks.