Allow to measure create/restore snapshot speed #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we add the ability to measure throughput (in byte/s) of the create snapshot and restore snapshot operations (the latter is piggybacked on shard recovery in Elasticsearch). To have Rally report the actual throughput of the server-side operation, the respective runners don't take the response time of Elasticsearch into account but rather how long the operation actually took. We also provide additional meta-data how many bytes have been snapshotted / recovered. All this let's us calculate the throughput in byte/s which is more meaningful than the actual response time of the request.
danielmitterdorfer
added
enhancement
dliappis
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we add the ability to measure throughput (in byte/s)
of the create snapshot and restore snapshot operations (the latter is
piggybacked on shard recovery in Elasticsearch). To have Rally report
the actual throughput of the server-side operation, the respective
runners don't take the response time of Elasticsearch into account but
rather how long the operation actually took. We also provide additional
meta-data how many bytes have been snapshotted / recovered. All this
let's us calculate the throughput in byte/s which is more meaningful
than the actual response time of the request.