Treat some zero target-intervals as unthrottled #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we adjust the predicate that considers a task as unthrottled. Previously a task was unthrottled if and only if its target throughput property was not defined and there was also not schedule set. This lead to problems when a target-interval of zero was set on task with an explicitly defined schedule (such as poisson). Now we treat tasks as unthrottled if and only if the target throughput property is not defined and the schedule is either unspecified or one of the built-in schedules. This ensures that a target-interval of zero is recognized as unthrottled for all built-in schedulers. Closes elastic#1120
danielmitterdorfer
added
bug
hub-cap
approved these changes
Nov 24, 2020
| def test_task_with_scheduler_is_throttled(self): | ||
| task = self.task(schedule="daily-traffic-pattern") | ||
| def test_target_interval_zero_treated_as_unthrottled(self): | ||
| task = self.task(target_interval=0) | ||
| self.assertIsNone(task.target_throughput) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we adjust the predicate that considers a task as
unthrottled. Previously a task was unthrottled if and only if its target
throughput property was not defined and there was also not schedule set.
This lead to problems when a target-interval of zero was set on task
with an explicitly defined schedule (such as poisson). Now we treat
tasks as unthrottled if and only if the target throughput property is
not defined and the schedule is either unspecified or one of the
built-in schedules. This ensures that a target-interval of zero is
recognized as unthrottled for all built-in schedulers.
Closes #1120