Allow to filter tasks by tag #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we allow users to filter tasks by tags. Tasks define a new property `tags` and we add a new `tag` keyword prefix for task filters. A usage example is: ``` --exclude-tasks="tag:setup" ``` By adding this task filter, Rally executes all tasks but the ones that contain this tag.
danielmitterdorfer
added
enhancement
gingerwizard
approved these changes
Jan 18, 2021
| self.tag_name = tag_name | ||
|
|
||
| def matches(self, task): | ||
| return self.tag_name in task.tags |
There was a problem hiding this comment.
This appears to mean case sensitive matching? Is this what we want? I assume include-tasks is currently case sensitive?
There was a problem hiding this comment.
Correct, this behavior is consistent with current behavior, i.e. all other task filters are also case-sensitive.
There was a problem hiding this comment.
I pushed an additional note in the docs about case sensitivity of task filters in 6cd13b2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we allow users to filter tasks by tags. Tasks define a
new property
tagsand we add a newtagkeyword prefix for taskfilters. A usage example is:
By adding this task filter, Rally executes all tasks but the ones that
contain this tag.