Make some document properties extensible #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Documents` domain class currently assumes static corpora and thus populates all properties eagerly via instance fields. There are cases however when we want to resolve these attributes lazily because the respective set of documents is generated at a later stage in the benchmark and we cannot derive these properties upfront. With this commit we make the relevant properties extensible so they can be resolved lazily in subclass implementations.
danielmitterdorfer
added
enhancement
|
Note to reviewers: I was pondering to expose all instance fields via properties but opted against it because it would make the implementation of this class much larger for little value (except consistency). |
DJRickyB
reviewed
Jan 28, 2021
| @@ -227,6 +227,30 @@ def has_compressed_corpus(self): | |||
| def has_uncompressed_corpus(self): | |||
| return self.document_file is not None | |||
|
|
|||
| @property | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Documentsdomain class currently assumes static corpora and thuspopulates all properties eagerly via instance fields. There are cases
however when we want to resolve these attributes lazily because the
respective set of documents is generated at a later stage in the
benchmark and we cannot derive these properties upfront. With this
commit we make the relevant properties extensible so they can be
resolved lazily in subclass implementations.