Expose an API to handle file offset tables #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we encapsulate handling of file offset tables for data files in a dedicated class. This class implements the necessary low-level handling only exposing a higher-level API for consumers. Closes elastic#1204
danielmitterdorfer
added
enhancement
gingerwizard
approved these changes
Mar 15, 2021
| :param data_file_path: The absolute path to the data file. This file is assumed to exist at this point. | ||
| :param offset_table_path: The absolute path to the corresponding offset table file. Only required to exist | ||
| for read operations on the data file. | ||
| :param mode: The mode in which the file offset table should be opened. |
There was a problem hiding this comment.
Can we not infer this? If an offset file is provided we can always open for read?
There was a problem hiding this comment.
never mind this will never be called directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we encapsulate handling of file offset tables for data
files in a dedicated class. This class implements the necessary
low-level handling only exposing a higher-level API for consumers.
Closes #1204