Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store relative-time in milliseconds #1221

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Store relative-time in milliseconds #1221

merged 1 commit into from
Mar 29, 2021

Conversation

danielmitterdorfer
Copy link
Member

Previously relative-time has denoted the relative time in microseconds
since the start of a task. This is inconvenient as all other times are
denoted in milliseconds. Therefore, we will migrate this field to be
denoted in milliseconds as well. In the first step we deprecate the
current field and introduce a new field relative-time-ms that is used
for the transition period.

Relates #1198

@danielmitterdorfer
Store relative-time in milliseconds
b159d61 
Previously `relative-time` has denoted the relative time in microseconds
since the start of a task. This is inconvenient as all other times are
denoted in milliseconds. Therefore, we will migrate this field to be
denoted in milliseconds as well. In the first step we deprecate the
current field and introduce a new field `relative-time-ms` that is used
for the transition period.

Relates elastic#1198
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Metrics How metrics are stored, calculated or aggregated labels Mar 26, 2021
@danielmitterdorfer danielmitterdorfer added this to the 2.1.0 milestone Mar 26, 2021
@danielmitterdorfer danielmitterdorfer self-assigned this Mar 26, 2021
@danielmitterdorfer
Copy link
Member Author

I did not mark this PR as breaking as Rally will continue to work as before although relative-time is now deprecated. The newly introduced field relative-time-ms will just be added to new metrics documents, even if they are added to an existing index.

@danielmitterdorfer danielmitterdorfer mentioned this pull request Mar 26, 2021
Merged
dliappis
dliappis approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

As discussed elsewhere, we could consider adding a unit field in a future PR.

@dliappis dliappis merged commit 894eca4 into elastic:master Mar 29, 2021
@dliappis dliappis mentioned this pull request Mar 31, 2021
Closed
4 tasks
@danielmitterdorfer danielmitterdorfer deleted the deprecate-relative-time branch April 6, 2021 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

Assignees

@danielmitterdorfer danielmitterdorfer

Labels
enhancement Improves the status quo :Metrics How metrics are stored, calculated or aggregated
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmitterdorfer @dliappis