Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Python client to 7.14.0 #1302

Merged
merged 8 commits into from
Sep 6, 2021
Merged

Upgrade Python client to 7.14.0 #1302

merged 8 commits into from
Sep 6, 2021

Conversation

danielmitterdorfer
Copy link
Member

With this commit we upgrade the Python client to 7.14.0.

Relates #1272

@danielmitterdorfer
Upgrade Python client to 7.14.0
4d87489 
With this commit we upgrade the Python client to 7.14.0.

Relates elastic#1272
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Jul 13, 2021
@danielmitterdorfer danielmitterdorfer self-assigned this Jul 13, 2021
@sethmlarson
Copy link
Contributor

The NotElasticsearchError is legitimate, caused by using the OSS distribution of Elasticsearch instead of the Basic/Elastic license. Added an additional --car-params=docker_image:docker.elastic.co/elasticsearch/elasticsearch fixed the problem locally for me, trying now on CI.

@sethmlarson
Copy link
Contributor

jenkins test this please

@danielmitterdorfer
Copy link
Member Author

danielmitterdorfer commented Jul 16, 2021 •
edited
Loading

Even after my latest changes in #1304 (merged into this branch), we still have issues, e.g.:

esrally race --distribution-version=6.8.0 --test-mode --track=geonames --on-error=abort --car=defaults,basic-license --track-params="bulk_indexing_clients:1"

This requires investigation.

@danielmitterdorfer
Copy link
Member Author

@elasticmachine test this please

@danielmitterdorfer danielmitterdorfer added this to the 2.3.0 milestone Jul 21, 2021
@sethmlarson
Copy link
Contributor

@elasticmachine test this please

@b-deam b-deam self-assigned this Aug 23, 2021
@b-deam b-deam marked this pull request as ready for review August 31, 2021 06:37
@b-deam
Copy link
Member

b-deam commented Aug 31, 2021

@dliappis / @ebadyano / @DJRickyB - whilst @danielmitterdorfer is out I ran some tests to verify whether the client version upgrade would introduce any obvious regressions in performance and so far there doesn't appear to be anything obvious (see #1272 (comment)).

dliappis
dliappis approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the thorough work to validate whether there are any performance changes introduced by this change.

LGTM

@b-deam b-deam merged commit 21e844e into elastic:master Sep 6, 2021
@b-deam b-deam mentioned this pull request Sep 7, 2021
Closed
@danielmitterdorfer danielmitterdorfer deleted the es-py-7-14 branch November 11, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

@ebadyano ebadyano Awaiting requested review from ebadyano

@DJRickyB DJRickyB Awaiting requested review from DJRickyB

Assignees

@danielmitterdorfer danielmitterdorfer

@b-deam b-deam

Labels
enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@danielmitterdorfer @sethmlarson @b-deam @dliappis