-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rally-* index template settings to default to Elasticsearch defaults #1312
Conversation
As discussed offline let's change the logic to default to |
As discussed, I've reworked the PR to meet the new requirements we discussed above ^^ The number of primary and replica shards are still configurable via In addition, we also remove the hardcoded
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left a comment about making the docs about the default value more factual.
Alrighty - I think I've addressed the comments and added a couple new tests. Can you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but we need to print the right ini file, honoring custom ini file invocations too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a small bug left.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In #1309 we addedconfigurable shard and replica shard counts to
rally.ini
.In that commit, the default number of replicas was set to 0,
which is trappy given that Elasticsearch defaults to 1 replica.
This commit changes the default behaviour to add 1 replica tothe
rally-*
indices by default.See comment: #1312 (comment)