Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'root' attribute to Track class #1461

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Add 'root' attribute to Track class #1461

merged 2 commits into from
Mar 21, 2022

Conversation

DJRickyB
Copy link
Contributor

This change adds a root attribute to the Track class, in order to provide an absolute path to original track files to any consumers, such as custom parameter sources.

@DJRickyB DJRickyB added the enhancement Improves the status quo label Mar 21, 2022
@DJRickyB DJRickyB added this to the 2.4.0 milestone Mar 21, 2022
@DJRickyB DJRickyB self-assigned this Mar 21, 2022
dliappis
dliappis approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left a question of small importance.

esrally/track/loader.py Show resolved Hide resolved
@DJRickyB DJRickyB merged commit 37f4a5f into elastic:master Mar 21, 2022
@DJRickyB DJRickyB deleted the provide_track_root branch March 21, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

@michaelbaamonde michaelbaamonde Awaiting requested review from michaelbaamonde

Assignees

@DJRickyB DJRickyB

Labels
enhancement Improves the status quo
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DJRickyB @dliappis