Link to the 7.14.0 ES Python client docs. #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the version that Rally depends on, so pointing users elsewhere could be misleading.
|
@elasticmachine run tests please |
|
Test failures appear to be due to a network error when attempting to build the Docker image. |
|
@elasticmachine run tests please |
1 similar comment
|
@elasticmachine run tests please |
dliappis
reviewed
Aug 3, 2022
docs/command_line_reference.rst
Outdated
| @@ -663,7 +663,7 @@ By default, the command line reporter will print the results only on standard ou | |||
|
|
|||
| With this option you can customize Rally's internal Elasticsearch client. | |||
|
|
|||
| It accepts a list of comma-separated key-value pairs. The key-value pairs have to be delimited by a colon. These options are passed directly to the Elasticsearch Python client API. See `their documentation on a list of supported options <http://elasticsearch-py.readthedocs.io/en/master/api.html#elasticsearch.Elasticsearch>`_. | |||
| It accepts a list of comma-separated key-value pairs. The key-value pairs have to be delimited by a colon. These options are passed directly to the Elasticsearch Python client API. See `their documentation on a list of supported options <https://elasticsearch-py.readthedocs.io/en/v7.14.0/api.html#elasticsearch>`_. | |||
There was a problem hiding this comment.
For the sake of not having to remember changing the version here when we upgrade elasticsearch[async] could we leverage a variable, similar to how we do for MIN_PY_VER? This is achieved with real python code on docs/conf.py so we could determine the version programmatically.
There was a problem hiding this comment.
Perfect, didn't even occur to me. I'll do that.
There was a problem hiding this comment.
Done in 8fb9a3d
|
@elasticmachine run tests please |
DJRickyB
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the version that Rally depends on, so pointing users elsewhere could be misleading.