Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject serverless_operator in track templates #1787

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

gbanasiak
Copy link
Contributor

Logical continuation of #1750 with additional global variable serverless_operator. The variable holds true if Rally detects serverless cluster and operator privileges, and false otherwise.

I've extended unit tests to cover the addition. For manual tests I've used custom track definition with the following bits:

# track json
{% import "rally.helpers" as rally with context %}
{
  "version": 2,
  [..]
  "indices": [
    {
      "name": "test-index",
      "body": "test-index.json"
    }
  ],
[..]

# test-index.json
{
    "mappings": {
      [..]
    },
    "settings": {
        "index": {
{% if build_flavor != "serverless" or serverless_operator %}
            "number_of_replicas": "{{number_of_replicas | default(0)}}",
            "number_of_shards": "{{number_of_shards | default(2)}}"
{% endif %}
        }
    }
}

@gbanasiak gbanasiak added enhancement Improves the status quo breaking Non-backwards compatible change labels Sep 27, 2023
@gbanasiak gbanasiak requested review from pquentin and a team and removed request for pquentin September 27, 2023 20:18
@gbanasiak gbanasiak added this to the 2.10.0 milestone Oct 2, 2023
Copy link

@dpifke-elastic dpifke-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

docs/migrate.rst Outdated Show resolved Hide resolved
gbanasiak and others added 2 commits October 3, 2023 09:46
Co-authored-by: Brad Deam <54515790+b-deam@users.noreply.github.com>
Copy link
Member

@gareth-ellis gareth-ellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbanasiak gbanasiak merged commit b18e0b4 into elastic:master Oct 3, 2023
15 checks passed
@gbanasiak gbanasiak deleted the inject-serverless-operator branch October 3, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Non-backwards compatible change enhancement Improves the status quo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants