Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to use track parameters in index definition #470

Merged
merged 1 commit into from
Apr 17, 2018
Merged

Allow to use track parameters in index definition #470

merged 1 commit into from
Apr 17, 2018

Conversation

danielmitterdorfer
Copy link
Member

Previously we forgot to pass track parameters to the
TrackSpecificationReader. As a consequence, we could not use track
parameters in index definitions as they were always empty.

With this commit we finally pass them there as well fixing the issue
above.

@danielmitterdorfer
Allow to use track parameters in index definition
47b630d 
Previously we forgot to pass track parameters to the
`TrackSpecificationReader`. As a consequence, we could not use track
parameters in index definitions as they were always empty.

With this commit we finally pass them there as well fixing the issue
above.
@danielmitterdorfer danielmitterdorfer added bug Something's wrong :Track Management New operations, changes in the track format, track download changes and the like labels Apr 17, 2018
@danielmitterdorfer danielmitterdorfer added this to the 0.10.1 milestone Apr 17, 2018
dliappis
dliappis approved these changes Apr 17, 2018
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this fixes the change introduced in 76b29cc (PR Relates #456) so perhaps we could add this info in the PR body / commit message too here as well?

@danielmitterdorfer
Copy link
Member Author

Thanks for the review. It does not relate to #456 but rather #429. I can mention it in the commit comment.

@danielmitterdorfer danielmitterdorfer merged commit 30517fb into elastic:master Apr 17, 2018
@danielmitterdorfer danielmitterdorfer deleted the pass-params branch April 20, 2018 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

Assignees
No one assigned
Labels
bug Something's wrong :Track Management New operations, changes in the track format, track download changes and the like
Projects
None yet
Milestone
0.10.1
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmitterdorfer @dliappis