Report indexing times per shard #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we do not only show the total indexing times (across all shards) but also report the indexing times per (primary) shard. Closes elastic#374
danielmitterdorfer
added
enhancement
danielmitterdorfer
removed
the
:Metrics
dliappis
approved these changes
May 30, 2018
| @@ -665,19 +705,38 @@ def report_merge_part_times(self, baseline_stats, contender_stats): | |||
| ) | |||
|
|
|||
| def report_total_times(self, baseline_stats, contender_stats): | |||
| totals = [] | |||
| totals += self.report_total_time("indexing time", | |||
There was a problem hiding this comment.
As discussed, append() could be a better choice as += with lists may produce unexpected results if the input is a string vs a list.
There was a problem hiding this comment.
Yes, good suggestion! I'll merge this PR and do this separately.
There was a problem hiding this comment.
Addressed in 8d7a799.
danielmitterdorfer
added a commit
that referenced
this pull request
May 30, 2018
With this commit we use a custom structure in the ES metrics store for per shard statistics instead of the generic `value.single` one. Relates #514
danielmitterdorfer
added a commit
that referenced
this pull request
May 30, 2018
With this commit we specify that values should be stored as doubles instead of floats (which are implicitly assumed) in order to ensure that we can store larger values as well. Relates #514
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we do not only show the total indexing times (across
all shards) but also report the indexing times per (primary) shard.
Closes #374