Don't fail git clone is tty is not attached #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/utils/git_test.py
Outdated
| run_subprocess.return_value = False | ||
| @mock.patch("esrally.utils.process.run_subprocess_with_logging") | ||
| def test_clone_successful(self, run_subprocess_with_logging, ensure_dir): | ||
| run_subprocess_with_logging.return_value = False |
There was a problem hiding this comment.
Should we actually set the return code instead of returning a boolean?
Suggested change
| run_subprocess_with_logging.return_value = False | |
| run_subprocess_with_logging.return_value = 0 |
There was a problem hiding this comment.
Indeed, 0 should be the right value here. Will fix, thanks.
Switch to `run_subprocess_with_logging` to provide some logs on failures when executing `git clone` and not rely on an attached tty (in case the daemon's been restarted with some automation in a non-interactive shell).
dliappis
force-pushed
the
clone_with_logging
branch
from
88532e4
to
9fb1bb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to
run_subprocess_with_loggingto provide some logs onfailures when executing
git cloneand not rely on an attachedtty (in case the daemon's been restarted with some automation in a
non-interactive shell).