Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refresh/merge/flush totals in summary #615

Merged
merged 3 commits into from
Dec 14, 2018

Commits on Dec 10, 2018

  1. Add refresh/merge/flush totals in summary

    Due to elastic#608 it's likely we need to benchmark scenarios without using
    the node-stats telemetry device. At the same time we want to get a
    general idea of how many refreshes/merges/flushes happened (in total)
    by accessing the index stats.
    
    Add total count for merges/refresh/flush in summary output; this is
    collected from `_all/primaries` in `_stats`.
    
    Also modify summary description to clarify the values are totals from
    primary shards.
    
    Finally fix bug where index stats where time/count == 0 got skipped
    from the summary.
    
    Closes elastic#614
    dliappis committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    ced08a4 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2018

  1. Address PR comments

    And group total counts directly below total times in all summary reports.
    dliappis committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    83d3f42 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2018

  1. Switch to Cumulative instead of Total for summary

    Use cumulative instead of total for summary reports and comparisons
    and clarify that min/median/max are across primary shards.
    
    Relates: elastic/elasticsearch#35594 (comment)
    dliappis committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    3d12203 View commit details
    Browse the repository at this point in the history