Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix home directory paths in provisioner_test. #699

Merged
merged 2 commits into from
May 30, 2019
Merged

Fix home directory paths in provisioner_test. #699

merged 2 commits into from
May 30, 2019

Conversation

drawlerr
Copy link
Contributor

No description provided.

dliappis
dliappis requested changes May 30, 2019
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot of catching and fixing this!

I left a request to switch away from f-Strings, unfortunately, as we still support 3.5 environments and this will break integration tests. Also left a minor comment about consistency in grabbing HOME.

tests/mechanic/provisioner_test.py Outdated Show resolved Hide resolved
tests/mechanic/provisioner_test.py Outdated Show resolved Hide resolved
@dliappis dliappis added :misc Changes that don't affect users directly: linter fixes, test improvements, etc. bug Something's wrong labels May 30, 2019
@dliappis dliappis added this to the 1.2.0 milestone May 30, 2019
@drawlerr drawlerr requested a review from dliappis May 30, 2019 15:10
dliappis
dliappis approved these changes May 30, 2019
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks.

@drawlerr drawlerr merged commit 9e4c1d3 into elastic:master May 30, 2019
@drawlerr drawlerr deleted the fix-test-rally-dir branch May 30, 2019 20:47
@dliappis dliappis modified the milestones: 1.2.0, 1.2.1 Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

@danielmitterdorfer danielmitterdorfer Awaiting requested review from danielmitterdorfer

@ebadyano ebadyano Awaiting requested review from ebadyano

Assignees
No one assigned
Labels
bug Something's wrong :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@drawlerr @dliappis