Option track-revision should work with track-repository

[ebadyano]

Both options track-repository and track-revision should work together but not with track-path option.

Fixes: #740

[dliappis]

Thanks for the PR!

This works fine and all tests seem to pass.

I left a request to add an integration test to ensure we catch future regressions.

[dliappis]

Could we add an integration test?

We could use the list command:

rally/integration-test.sh

Lines 219 to 233 in 966891a

	function test_list {
	local cfg
	random_configuration cfg
	info "test list races [${cfg}]"
	esrally list races --configuration-name="${cfg}"
	info "test list cars [${cfg}]"
	esrally list cars --configuration-name="${cfg}"
	info "test list Elasticsearch plugins [${cfg}]"
	esrally list elasticsearch-plugins --configuration-name="${cfg}"
	info "test list tracks [${cfg}]"
	esrally list tracks --configuration-name="${cfg}"
	info "test list telemetry [${cfg}]"
	esrally list telemetry --configuration-name="${cfg}"
	}

and, in order to avoid having to add the eventdata repo in the rally.ini used by the integration script (which is randomized btw), we could just rely on the default repository with something like:

   info "test list can use track revision together with track repository"
    esrally list tracks --configuration-name="${cfg}" --track-repository=default --track-revision=4080dc9850d07e23b6fc7cfcdc7cf57b14e5168d
}

[ebadyano]

Sure I will add it to the integration tests.

[dliappis]

LGTM thanks